Messages in this thread | | | Date | Mon, 23 Dec 2013 19:46:17 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH -tip 1/3] [CLEANUP] perf-probe: Expand given path to absolute path |
| |
(2013/12/23 15:17), Namhyung Kim wrote: > Hi Masami, > > On Fri, 20 Dec 2013 10:02:57 +0000, Masami Hiramatsu wrote: >> Expand given path to absolute path in option parser, >> except for a module name. Instead of expanding it later, >> this get the absolute path in early stage. >> >> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> >> --- >> tools/perf/builtin-probe.c | 9 +++++++++ >> tools/perf/util/probe-event.c | 11 ++--------- >> 2 files changed, 11 insertions(+), 9 deletions(-) >> >> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c >> index 6ea9e85..b40d064 100644 >> --- a/tools/perf/builtin-probe.c >> +++ b/tools/perf/builtin-probe.c >> @@ -180,6 +180,15 @@ static int opt_set_target(const struct option *opt, const char *str, >> else >> return ret; >> >> + /* Expand given path to absolute path, except for modulename */ >> + if (params.uprobes || strchr(str, '/')) { >> + str = realpath(str, NULL); >> + if (!str) { >> + pr_warning("Failed to find the path of %s.\n", >> + str); > > It won't print the path since the str already was overwritten to NULL.
Oops ...
>> + return ret; >> + } >> + } >> params.target = str; > > It now points either a dynamically allocated string or not..
Ah, right. OK, I'll use strdup for such case.
Thank you!
-- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
| |