Messages in this thread | | | Date | Tue, 24 Dec 2013 10:03:27 +0900 | From | Masami Hiramatsu <> | Subject | Re: Re: [PATCH -tip 2/3] perf-probe: Support dwarf on uprobe events |
| |
(2013/12/23 23:34), Arnaldo Carvalho de Melo wrote: > Em Mon, Dec 23, 2013 at 06:39:16AM +0900, Masami Hiramatsu escreveu: >> (2013/12/21 3:01), Arnaldo Carvalho de Melo wrote: >>> Em Fri, Dec 20, 2013 at 10:02:59AM +0000, Masami Hiramatsu escreveu: >>>> Support dwarf(debuginfo) based operations for uprobe events. >>>> With this change, perf probe can analyze debuginfo of user >>>> application binary to set up new uprobe event. >>>> This allows perf-probe --add/--line works with -x option. >>>> (Actually, --vars has already accepted -x option) >>> >>> Can you provide an example? >>> >> >> OK, here is the examples from 0/3. :) > > Pleasn readnthis message: > > http://lkml.kernel.org/r/20131218141125.GT21999@twins.programming.kicks-ass.net > > It is unrelated to this code being discussed in this thread, but > provides another request for having better patch descriptions and to > have relevant discussion in the corresponding patch, not just on "0/N".
OK, I'll take care of it.
> >> Or, should I better put this into the patch description too? > > Sure thing, please!
I see, I'll update it with the examples in the next version.
> >> For example) >> - Shows the probe-able lines of the given function > > The above line would be more clear as: > > "The following command shows the probe-able lines of a given user space > function, something that so far was only available in the 'perf probe' > tool for kernel space functions:"
Thanks! :)
-- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
| |