Messages in this thread | | | Date | Sat, 14 Dec 2013 19:43:59 +0800 | Subject | Re: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid() | From | Zhi Yong Wu <> |
| |
On Sat, Dec 14, 2013 at 7:20 PM, Jeff Liu <jeff.liu@oracle.com> wrote: > On 12/14 2013 00:32 AM, Christoph Hellwig wrote: >>> +static inline prid_t xfs_get_initial_prid(struct xfs_inode *dp) >>> +{ >>> + if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT) >>> + return xfs_get_projid(dp); >>> + else >>> + return XFS_PROJID_DEFAULT; >>> +} >> >> You could skip the else here. > Except that, I'd suggest we move this helper to proper header file with > further refactoring in xfs_symlink(), and it could be a separate patch. Good point, will apply it, thanks.
> > Thanks, > -Jeff
-- Regards,
Zhi Yong Wu
| |