Messages in this thread | | | Date | Sat, 14 Dec 2013 19:20:17 +0800 | From | Jeff Liu <> | Subject | Re: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid() |
| |
On 12/14 2013 00:32 AM, Christoph Hellwig wrote: >> +static inline prid_t xfs_get_initial_prid(struct xfs_inode *dp) >> +{ >> + if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT) >> + return xfs_get_projid(dp); >> + else >> + return XFS_PROJID_DEFAULT; >> +} > > You could skip the else here. Except that, I'd suggest we move this helper to proper header file with further refactoring in xfs_symlink(), and it could be a separate patch.
Thanks, -Jeff
| |