Messages in this thread | | | Date | Mon, 7 Oct 2013 10:49:43 -0700 | From | Brian Norris <> | Subject | Re: [PATCH] mtd: phram: Make phram 64-bit compatible |
| |
+ LKML
On Wed, Oct 02, 2013 at 06:42:29PM +0200, Alexander Sverdlin wrote: > mtd: phram: Make phram 64-bit compatible > > phram was 32-bit limited by design. Machines are growing up, but phram > module is still useful. Update it. The patch is bigger than minimum, > because simple_strtoul() is obsolete. > > Tested on MIPS64 and compile-tested for PPC (32 bit). > > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nsn.com>
Pushed to l2-mtd.git. Thanks!
Can this driver use the library memparse() function instead of open-coding it?
[To answer myself:] I noticed this in drivers/mtd/devices/phram.c, which prevents us from using memparse():
/* By dwmw2 editorial decree, "ki", "Mi" or "Gi" are to be used. */
Are we (MTD) holding a revolutionary position against the standard kernel libraries, which recognize [KkMmGg] prefixes, but not [kMG]i prefixes? Should we extend memparse() to accept either form? Or would doing so simply pollute the library and not really satisfy anyone?
[After more research:] It looks like this topic may be the subject of some long-past flame wars. If I am digging up past demons, then I'd prefer to let sleeping Balrogs lie.
Brian
| |