Messages in this thread | | | Date | Mon, 30 Sep 2013 21:21:53 -0700 (PDT) | Subject | Re: [PATCH] ll_temac: Reset dma descriptors on ndo_open | From | David Miller <> |
| |
From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Date: Fri, 27 Sep 2013 13:24:28 +0200
> The dma descriptors are only initialized on the probe function. > > If a packet is on the buffer when temac_stop is called, the dma > descriptors can be left on a incorrect status where no other package can > be sent. > > So an interface could be left in an usable state after ifdow/ifup. > > This patch makes sure that the descriptors are in a proper status when > the device is started. > > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
This analysis is not correct.
In the current driver, the descriptors are allocated and initialized in the open function, not the probe function.
I'm not applying this patch.
| |