[lkml]   [2013]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 06/13] sg_io: whitelist a few more commands for multimedia devices
Hello, Paolo.

On Sat, Jan 26, 2013 at 12:32:36AM +0100, Paolo Bonzini wrote:
> If I make a whitelist with all the commands that Linux sends, I'll have
> many new commands in the whitelist and no old commands. The new
> commands didn't exist when old drives were sold, so they are "dangerous"
> in your opinion. At that point I might as well keep the whitelist
> empty, no?

Let's not go to extremes. It's not about theoretic correctness. It's
about how to appraoch a possibly messy practical problem. To me, it
seems natural to be conservative on this and add what's being acitvely
used, which as a bonus will also give us at least some chance of
evaluating what we have and why later on if it ever needs to be

I'm just not comfortable with adding a bunch of commands by simply
scanning the specs. Let's at least have some backing data and
justification for exposing new ones. I really don't think that's too
much to ask. Start with minimal set. Grow it as needed. We can
always grow but the other direction is much harder.



 \ /
  Last update: 2013-01-26 01:23    [W:0.127 / U:4.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site