Messages in this thread | | | Date | Fri, 25 Jan 2013 09:28:05 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH 06/13] sg_io: whitelist a few more commands for multimedia devices |
| |
On Fri, Jan 25, 2013 at 06:16:04PM +0100, Paolo Bonzini wrote: > Well, you can find broken devices for pretty much every command in the > list. Anyhow, the other two commands are obsolete so I'm okay with > leaving them out, if only for the sake of avoiding useless email threads.
Once we open the commands to userland this way, it's difficult to throttle it back again. I just fail to see the point of allowing everything possible. There's a way to override it (is that in yet?) and we can always extend the list later, so please do the minimal set with justification and can you please stop labeling reviews as "useless"? For Pete's sake, if you disagree, just disagree and explain your point. How is discussion about which commands should be allowed via SG_IO "useless"? Gees...
-- tejun
| |