lkml.org 
[lkml]   [2013]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[perf PATCH 3/3] Fix double fclose() on do_write(fd, xxx) failure
Date
cppcheck reported:
[util/header.c:983]: (error) Used file that is not opened.

Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
---
tools/perf/util/header.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 7b24cf3..30745c2 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -955,6 +955,7 @@ static int write_topo_node(int fd, int node)
}

fclose(fp);
+ fp = NULL;

ret = do_write(fd, &mem_total, sizeof(u64));
if (ret)
--
1.7.11.7


\
 
 \ /
  Last update: 2013-01-26 00:22    [W:0.036 / U:7.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site