Messages in this thread Patch in this message | | | From | Peter Senna Tschudin <> | Subject | [PATCH 8/9] sound/soc/soc-core.c: Remove useless kfree | Date | Wed, 12 Sep 2012 17:06:46 +0200 |
| |
From: Peter Senna Tschudin <peter.senna@gmail.com>
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @r exists@ position p1,p2; expression x; @@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged exists@ position r.p1,r.p2; expression e <= r.x,x,e1; iterator I; statement S; @@
if (x@p1 == NULL) { ... when != I(x,...) S when != e = e1 when != e += e1 when != e -= e1 when != ++e when != --e when != e++ when != e-- when != &e kfree@p2(x); ... return ...; }
@ok depends on unchanged exists@ position any r.p1; position r.p2; expression x; @@
... when != true x@p1 == NULL kfree@p2(x);
@depends on !ok && unchanged@ position r.p2; expression x; @@
*kfree@p2(x); // </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
--- sound/soc/soc-core.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 2a4c7bb..6b29c73 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -4052,8 +4052,6 @@ int snd_soc_register_codec(struct device *dev, return 0; fail: - kfree(codec->reg_def_copy); - codec->reg_def_copy = NULL; kfree(codec->name); kfree(codec); return ret;
| |