Messages in this thread | | | From | Alexander van Heukelum <> | Subject | Re: [PATCH 5/6] ftrace/x86: Add separate function to save regs | Date | Tue, 03 Jul 2012 18:54:26 +0200 |
| |
On Mon, Jul 2, 2012, at 16:03, Steven Rostedt wrote: > Email had 1 attachment: > + 0005-ftrace-x86-Add-separate-function-to-save-regs.patch > 23k (text/plain)
Hi Steven,
One thing that caught my eye...
> diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S > index e3e17a0..acd4963 100644 > --- a/arch/x86/kernel/entry_32.S > +++ b/arch/x86/kernel/entry_32.S > @@ -1109,6 +1109,7 @@ ENTRY(ftrace_caller) > pushl %eax > pushl %ecx > pushl %edx > + pushl $0 /* Pass NULL as regs pointer */ > movl 0xc(%esp), %eax
This should now be changed to "0x10(%esp)", right?
Greetings, Alexander
> movl 0x4(%ebp), %edx > leal function_trace_op, %ecx > @@ -1118,6 +1119,7 @@ ENTRY(ftrace_caller) > ftrace_call: > call ftrace_stub > > + addl $4,%esp /* skip NULL pointer */ > popl %edx > popl %ecx > popl %eax
| |