lkml.org 
[lkml]   [2012]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5/6] ftrace/x86: Add separate function to save regs
From
Date
On Tue, 2012-07-03 at 18:54 +0200, Alexander van Heukelum wrote:
> On Mon, Jul 2, 2012, at 16:03, Steven Rostedt wrote:
> > Email had 1 attachment:
> > + 0005-ftrace-x86-Add-separate-function-to-save-regs.patch
> > 23k (text/plain)
>
> Hi Steven,
>
> One thing that caught my eye...
>
> > diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
> > index e3e17a0..acd4963 100644
> > --- a/arch/x86/kernel/entry_32.S
> > +++ b/arch/x86/kernel/entry_32.S
> > @@ -1109,6 +1109,7 @@ ENTRY(ftrace_caller)
> > pushl %eax
> > pushl %ecx
> > pushl %edx
> > + pushl $0 /* Pass NULL as regs pointer */
> > movl 0xc(%esp), %eax
>
> This should now be changed to "0x10(%esp)", right?

Yeah, I think you're right. Actually, I think I originally had it as:

movl 0xc(%esp), %eax
+ pushl $0

But after a few other changes, it went to this. I haven't finished
testing against x86_64, and haven't started the i386 tests. I'm sure
this would have blown up then ;-)

Thanks,

-- Steve


>
> Greetings,
> Alexander
>
> > movl 0x4(%ebp), %edx
> > leal function_trace_op, %ecx
> > @@ -1118,6 +1119,7 @@ ENTRY(ftrace_caller)
> > ftrace_call:
> > call ftrace_stub
> >
> > + addl $4,%esp /* skip NULL pointer */
> > popl %edx
> > popl %ecx
> > popl %eax




\
 
 \ /
  Last update: 2012-07-05 23:21    [W:0.111 / U:40.360 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site