| Date | Thu, 26 Jul 2012 10:59:08 +0800 | Subject | Re: [RFC PATCH 08/13] driver core: firmware loader: fix device lifetime | From | Ming Lei <> |
| |
On Thu, Jul 26, 2012 at 12:04 AM, Borislav Petkov <bp@amd64.org> wrote: >> Also this patch holds the reference cound of @device before > > count
Good catch, will fix it in -v1.
>> - * it is not possible to sleep for long time. It can't be called >> - * in atomic contexts. >> + * it is not possible to sleep for long time. > > Let's state it explicitly: > > "it is not allowed to sleep for it is called in atomic context."
Looks you understand it incorrectly, the sentence is below
* Asynchronous variant of request_firmware() for user contexts where * it is not possible to sleep for long time.
and maybe it should be changed to below:
* Asynchronous variant of request_firmware() for user contexts where * it is not possible to sleep for long time or can't sleep at all.
Thanks, -- Ming Lei
|