Messages in this thread | | | Date | Fri, 13 Jul 2012 09:54:04 -0600 | From | Khalid Aziz <> | Subject | Re: [PATCH] Add missing attributes to EFI variable attribute print out from sysfs |
| |
On 07/13/2012 09:46 AM, Matthew Garrett wrote: > On Fri, Jul 13, 2012 at 09:38:27AM -0600, Khalid Aziz wrote: >> if (var->Attributes & 0x4) >> str += sprintf(str, "EFI_VARIABLE_RUNTIME_ACCESS\n"); > I know you're just following the pattern of the existing code, but could > you change these to be more like > > if (var->Attributes & EFI_VARIABLE_RUNTIME_ACCESS) > > while you're at it? I think that'd be a worthwhile cleanup. >
That is a good suggestion. I will make the changes and send out updated version.
-- Khalid Aziz khalid.aziz@hp.com
| |