Messages in this thread | | | Date | Fri, 13 Jul 2012 12:05:52 -0600 | From | Khalid Aziz <> | Subject | Re: [PATCH] Add missing attributes to EFI variable attribute print out from sysfs |
| |
On 07/13/2012 11:54 AM, Matthew Garrett wrote: > On Fri, Jul 13, 2012 at 11:52:15AM -0600, Khalid Aziz wrote: >> EFI_VARIABLE_NON_VOLATILE -> EFI_VAR_NV >> EFI_VARIABLE_BOOTSERVICE_ACCESS -> EFI_VAR_BOOT >> EFI_VARIABLE_RUNTIME_ACCESS -> EFI_VAR_RUNTIME >> EFI_VARIABLE_HARDWARE_ERROR_RECORD -> EFI_VAR_HW_ERROR >> EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS -> EFI_VAR_AUTH_WRITE >> EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS -> EFI_VAR_TIMED_AUTH_WRITE >> EFI_VARIABLE_APPEND_WRITE -> EFI_VAR_APPEND >> >> Sounds reasonable? > Sounds great, but sadly they're exposed to userspace so changing them > would be a problem. Adding aliases would be ugly but workable? >
Ugly but practical. I agree with creating alias. I can work up a patch that creates the aliases in efi.h, and replaces all uses in kernel with shorter names. This does not change ABI or API, so existing userspace programs will continue to work.
-- Khalid Aziz khalid.aziz@hp.com
| |