lkml.org 
[lkml]   [2012]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited
> On 12/07/12 21:18, Raghavendra K T wrote:
> > +#ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT
> [...]
> > + struct {
> > + bool cpu_relax_intercepted;
> > + bool dy_eligible;
> > + } ple;
> > +#endif
> [...]
> > }
> > vcpu->run = page_address(page);
> > + vcpu->ple.cpu_relax_intercepted = false;
> > + vcpu->ple.dy_eligible = false;
>
> This struct is only defined if CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT is set, but here it
> is always accessed. Will break on !x86 && !s390.

How about moving this struct definition outside the CONFIG.
i.e it would be available by default.
If any arch cares to use vcpu_on_spin(), they would get the benefit by
default.

This would avoid all the CONFIG magic that we would have to do
otherwise.

--
Thanks and Regards
Srikar



\
 
 \ /
  Last update: 2012-07-13 16:41    [W:0.106 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site