lkml.org 
[lkml]   [2012]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited
    On 12/07/12 21:18, Raghavendra K T wrote:
    > +#ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT
    [...]
    > + struct {
    > + bool cpu_relax_intercepted;
    > + bool dy_eligible;
    > + } ple;
    > +#endif
    [...]
    > }
    > vcpu->run = page_address(page);
    > + vcpu->ple.cpu_relax_intercepted = false;
    > + vcpu->ple.dy_eligible = false;

    This struct is only defined if CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT is set, but here it
    is always accessed. Will break on !x86 && !s390.
    >
    > r = kvm_arch_vcpu_init(vcpu);
    > if (r < 0)
    > @@ -1577,6 +1579,7 @@ void kvm_vcpu_on_spin(struct kvm_vcpu *me)
    > int pass;
    > int i;
    >
    > + me->ple.cpu_relax_intercepted = true;

    dito
    > /*
    > * We boost the priority of a VCPU that is runnable but not
    > * currently running, because it got preempted by something
    > @@ -1602,6 +1605,7 @@ void kvm_vcpu_on_spin(struct kvm_vcpu *me)
    > }
    > }
    > }
    > + me->ple.cpu_relax_intercepted = false;

    again.

    maybe define static inline access functions in kvm_host.h that are no-ops
    if CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT is not set.



    \
     
     \ /
      Last update: 2012-07-12 22:41    [W:3.130 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site