Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH 4/7] fs/direct-io.c: adjust suspicious bit operation | Date | Thu, 07 Jun 2012 10:24:46 -0400 |
| |
Julia Lawall <Julia.Lawall@lip6.fr> writes:
> From: Julia Lawall <Julia.Lawall@lip6.fr> > > READ is 0, so the result of the bit-and operation is 0. Rewrite with == as > done elsewhere in the same file. > > This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
Interesting catch, that one. Yeah, we don't expect any readahead I/O to be done via O_DIRECT. The test for rw == READ all over that file seems fine to me, given that.
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
| |