lkml.org 
[lkml]   [2012]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/7] drivers/ide/ide-cs.c: adjust suspicious bit operation
From
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Wed, 6 Jun 2012 23:41:35 +0200

> - if (!(pdev->resource[0]->flags & IO_DATA_PATH_WIDTH_8)) {
> + if ((p1dev->resource[0]->flags & IO_DATA_PATH_WIDTH)

I'm really surprised someone as thorough as yourself did not
compile test this.

This is just more proof that it's absolutely pointless to make any
changes at all to the old IDE layer. Nobody really cares, and the
risk %99.999 of the time is purely to introduce regressions rather
than make forward progress.


\
 
 \ /
  Last update: 2012-06-08 00:21    [W:1.792 / U:0.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site