lkml.org 
[lkml]   [2012]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] kvm: don't clear level from irqfd
irqfd sets and clears the level immediately.
This used to be necessary for MSI interrupts but isn't anymore.

Note! We never officially supported irqfd for level
interrupts but it usually seemed to kind of work,
and this change will break it. There are no known
real users of that feature though - only old vfio prototypes.
Removing this line will make it easier to add
real support for level irqfds in the future.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
virt/kvm/eventfd.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
index f59c1e8..4db6b01 100644
--- a/virt/kvm/eventfd.c
+++ b/virt/kvm/eventfd.c
@@ -68,7 +68,6 @@ irqfd_inject(struct work_struct *work)
struct kvm *kvm = irqfd->kvm;

kvm_set_irq(kvm, KVM_USERSPACE_IRQ_SOURCE_ID, irqfd->gsi, 1);
- kvm_set_irq(kvm, KVM_USERSPACE_IRQ_SOURCE_ID, irqfd->gsi, 0);
}

/*
--
MST

\
 
 \ /
  Last update: 2012-06-27 12:41    [W:0.080 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site