lkml.org 
[lkml]   [2012]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/12] usb: fix sillies in the metro USB driver
    Date
    Bits noticed doing the termios conversion

    Signed-off-by: Alan Cox <alan@linux.intel.com>
    ---

    drivers/usb/serial/metro-usb.c | 8 +-------
    1 file changed, 1 insertion(+), 7 deletions(-)

    diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c
    index 81423f7..bad5f0c 100644
    --- a/drivers/usb/serial/metro-usb.c
    +++ b/drivers/usb/serial/metro-usb.c
    @@ -130,20 +130,14 @@ static void metrousb_read_int_callback(struct urb *urb)

    /* Set the data read from the usb port into the serial port buffer. */
    tty = tty_port_tty_get(&port->port);
    - if (!tty) {
    - dev_err(&port->dev, "%s - bad tty pointer - exiting\n",
    - __func__);
    - return;
    - }
    -
    if (tty && urb->actual_length) {
    /* Loop through the data copying each byte to the tty layer. */
    tty_insert_flip_string(tty, data, urb->actual_length);

    /* Force the data to the tty layer. */
    tty_flip_buffer_push(tty);
    + tty_kref_put(tty);
    }
    - tty_kref_put(tty);

    /* Set any port variables. */
    spin_lock_irqsave(&metro_priv->lock, flags);


    \
     
     \ /
      Last update: 2012-06-22 18:01    [W:0.023 / U:88.740 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site