[lkml]   [2012]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 06/12] 8250: use the 8250 register interface not the legacy one
    On Fri, Jun 22, 2012 at 04:43:51PM +0100, Alan Cox wrote:
    > @@ -69,7 +69,6 @@ struct uart_port;
    > struct uart_8250_port;
    > int serial8250_register_8250_port(struct uart_8250_port *);
    > -int serial8250_register_port(struct uart_port *);

    There are still in-kernel callers of this function, so I don't think
    it's safe to remove just yet, otherwise the build will break:

    drivers/char/mwave/mwavedd.c: return serial8250_register_port(&uart);
    drivers/misc/ibmasm/uart.c: sp->serial_line = serial8250_register_port(&uport);
    drivers/net/ethernet/sgi/ioc3-eth.c: serial8250_register_port(&port);
    drivers/tty/serial/of_serial.c: ret = serial8250_register_port(&port);

    I'm stopping here on this series, I've only applied the one that added
    the comment, that seems to be the only one that compiled properly :(

    Care to redo these please?


    greg k-h

     \ /
      Last update: 2012-06-27 05:21    [W:0.030 / U:3.548 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site