Messages in this thread | | | Date | Fri, 27 Apr 2012 10:01:40 +0900 | From | Simon Horman <> | Subject | Re: [PATCH] IPVS: ip_vs_ftp.c: local functions should not be exposed globally |
| |
On Thu, Apr 26, 2012 at 11:17:28AM -0700, H Hartley Sweeten wrote: > Functions not referenced outside of a source file should be marked > static to prevent it from being exposed globally. > > This quiets the sparse warnings: > > warning: symbol 'ip_vs_ftp_init' was not declared. Should it be static?
On Thu, Apr 26, 2012 at 11:26:15AM -0700, H Hartley Sweeten wrote: > Functions not referenced outside of a source file should be marked > static to prevent it from being exposed globally. > > This quiets the sparse warnings: > > warning: symbol '__ipvs_proto_data_get' was not declared. Should it be static? > > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> > Cc: "David S. Miller" <davem@davemloft.net>
Thanks, I have applied these to ipvs-next.
git://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs-next.git
| |