[lkml]   [2012]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] IPVS: ip_vs_proto.c: local functions should not be exposed globally
    Functions not referenced outside of a source file should be marked
    static to prevent it from being exposed globally.

    This quiets the sparse warnings:

    warning: symbol '__ipvs_proto_data_get' was not declared. Should it be static?

    Signed-off-by: H Hartley Sweeten <>
    Cc: "David S. Miller" <>


    diff --git a/net/netfilter/ipvs/ip_vs_proto.c b/net/netfilter/ipvs/ip_vs_proto.c
    index 6eda11d..d5d1d92 100644
    --- a/net/netfilter/ipvs/ip_vs_proto.c
    +++ b/net/netfilter/ipvs/ip_vs_proto.c
    @@ -153,7 +153,7 @@ EXPORT_SYMBOL(ip_vs_proto_get);
    * get ip_vs_protocol object data by netns and proto
    -struct ip_vs_proto_data *
    +static struct ip_vs_proto_data *
    __ipvs_proto_data_get(struct netns_ipvs *ipvs, unsigned short proto)
    struct ip_vs_proto_data *pd;

     \ /
      Last update: 2012-04-26 20:29    [W:0.023 / U:3.312 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site