lkml.org 
[lkml]   [2012]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v5]: Hibernation: lower/better control the amount of pages used for buffering
Date
On Wednesday, March 28, 2012, Bojan Smojver wrote:
> On Wed, 2012-03-28 at 00:41 +0200, Rafael J. Wysocki wrote:
> > If you define a macro, please use capital letters in the name. Also,
> > the parentheses aren't necessary I think.
> >
> > Perhaps it would be better to use a static inline function instead?
>
> Hmm, was just following the nr_free_pages() definition in swap.h:
>
> /* Definition of global_page_state not available yet */
> #define nr_free_pages() global_page_state(NR_FREE_PAGES)
>
> Still no good?

Not really, that should be a static inline too. :-)

Thanks,
Rafael


\
 
 \ /
  Last update: 2012-03-28 00:45    [W:0.068 / U:2.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site