lkml.org 
[lkml]   [2012]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5]: Hibernation: lower/better control the amount of pages used for buffering
From
Date
On Wed, 2012-03-28 at 00:41 +0200, Rafael J. Wysocki wrote:
> If you define a macro, please use capital letters in the name. Also,
> the parentheses aren't necessary I think.
>
> Perhaps it would be better to use a static inline function instead?

Hmm, was just following the nr_free_pages() definition in swap.h:

/* Definition of global_page_state not available yet */
#define nr_free_pages() global_page_state(NR_FREE_PAGES)

Still no good?

--
Bojan



\
 
 \ /
  Last update: 2012-03-28 00:43    [W:0.042 / U:6.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site