Messages in this thread | | | From | Santosh Y <> | Date | Tue, 27 Mar 2012 09:31:37 +0530 | Subject | Re: [PATCH v3 1/5] [SCSI] ufshcd: UFS Host controller driver |
| |
On Mon, Mar 26, 2012 at 10:02 AM, KOBAYASHI Yoshitake <yoshitake.kobayashi@toshiba.co.jp> wrote: >> > + utrdlp[i].response_upiu_length = >> > + cpu_to_le16(ALIGNED_UPIU_SIZE); > > > Response UPIU Length(RUL) shows the response UPIU length in Dword. > (JEDEC Standard No.223 6.2.1 UTP Transfer Request Descriptor) > The following will be correct. > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 07ec973..feffe65 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -836,7 +836,7 @@ static void ufshcd_host_memory_configure(struct ufs_hba > *hba) > utrdlp[i].prd_table_offset = > cpu_to_le16((prdt_offset >> 2)); > utrdlp[i].response_upiu_length = > - cpu_to_le16(ALIGNED_UPIU_SIZE); > + cpu_to_le16(ALIGNED_UPIU_SIZE >> 2); > > > hba->lrb[i].utr_descriptor_ptr = (utrdlp + i); > hba->lrb[i].ucd_cmd_ptr = >
Thanks, i'll update it.
-- ~Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |