lkml.org 
[lkml]   [2012]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v3 1/5] [SCSI] ufshcd: UFS Host controller driver
    > > +        utrdlp[i].response_upiu_length =
    > > + cpu_to_le16(ALIGNED_UPIU_SIZE);

    Response UPIU Length(RUL) shows the response UPIU length in Dword.
    (JEDEC Standard No.223 6.2.1 UTP Transfer Request Descriptor)
    The following will be correct.

    diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
    index 07ec973..feffe65 100644
    --- a/drivers/scsi/ufs/ufshcd.c
    +++ b/drivers/scsi/ufs/ufshcd.c
    @@ -836,7 +836,7 @@ static void ufshcd_host_memory_configure(struct ufs_hba *hba)
    utrdlp[i].prd_table_offset =
    cpu_to_le16((prdt_offset >> 2));
    utrdlp[i].response_upiu_length =
    - cpu_to_le16(ALIGNED_UPIU_SIZE);
    + cpu_to_le16(ALIGNED_UPIU_SIZE >> 2);

    hba->lrb[i].utr_descriptor_ptr = (utrdlp + i);
    hba->lrb[i].ucd_cmd_ptr =


    \
     
     \ /
      Last update: 2012-03-26 07:25    [W:6.066 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site