lkml.org 
[lkml]   [2012]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
Subject[PATCH 0/5] PERF fixes
From

This fixes the histogram out-of-date map entry issue as well
as other problems I hit or discovered along the way.

To be honest the histogram entry map pointer is completely
superfluous.

When histogram entries are being used when processing a perf
event, we have the computed and most uptodate map already
in the addr_location that has been built, so we can just
pass that map pointer down into perf_top__record_precise_ip()
and similar.

The other cases, when annotating, are also superfluous. We don't need
the map file at all to compute the address to pass into addr2line and
objdump. We have exactly two cases:

1) Dynamic object, use the raw unchanged address

2) ET_EXEC or .gnu.prelink_undo section, we can read the ELF file
PT_LOAD entries or similar to adjust the address properly.

So neither case needs the map pointer at all. Then all we're
left with are perf internal debugging printf's and those can
be simply removed.

Signed-off-by: David S. Miller <davem@davemloft.net>


\
 
 \ /
  Last update: 2012-03-25 22:31    [W:0.022 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site