lkml.org 
[lkml]   [2012]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH] regulator: i.MX35-PDK Add regulator support
Date
From: Alex <alexg@meprolight.com>

Hi Marc,

Thanks for the patches.

v4 3/4 not directly applicable to Linux version 3.3,
I installed it manually, you could check it out?

> > I'm not very experienced with the regulator driver, but noticed a couple of
> > minor things with your patch...

I think that my experience in the regulator driver a little less than you :-)

> static struct resource mx35pdk_flash_resource = {
> .start = MX35_CS0_BASE_ADDR,
> - .end = MX35_CS0_BASE_ADDR + SZ_64M - 1,
> + .end = MX35_CS0_BASE_ADDR + SZ_64M - 1,

> > did you mean to change this?

No, I will correct this.

> +static struct regulator_init_data vsd_init = {
> + .constraints = {
> + .name = "VSD",
> + .min_uV = 1800000,
> + .max_uV = 3150000,
> + .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE,
> + }
> +};

> > I think this is on at power up too (for imx35)

Maybe you're right, but in this case, the i.MX35 PDK
Do not use PMIC "VSD" regulator, but instead it is used
a different power source.
I think it can be removed from here :-)


Regards,
Alex Gershgorin






\
 
 \ /
  Last update: 2012-03-23 19:13    [W:0.038 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site