[lkml]   [2012]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/9] ext4: Use pr_fmt and pr_<level>
    On Thu, Mar 15, 2012 at 05:07:30PM -0700, Joe Perches wrote:
    > Use a more current logging style.
    > Add pr_fmt to consistently prefix with "EXT4-fs: "
    > Convert printks with KERN_<LEVEL> to pr_<level>.
    > Convert bare printks to pr_info and pr_cont where appropriate.
    > Remove embedded function names from formats, use "%s: ", __func__.
    > Coalesce formats.
    > Neaten macros that contain printks/pr_<level>.
    > Use ##__VA_ARGS__ in those macros.

    Still too much in a single patch.

    Changing printk's to pr_info and pr_cont is patch noise as far as I'm
    concerned. Adds no value, and just breaks other patches. Ditto using
    __func__ and and coalesing formats (much of which was broekn up back
    when checkpatch flamed developers about 80 column lines, and I patch
    noises from trivial patch monkeys offering to fix it, sigh).

    And I really don't care about adding EXT4-fs to debugging messages,
    especially messages which can't be enabled except when developers have
    to explicitly add #define's...

    One evidence that this patch is noise is that it doesn't apply cleanly
    just on top of my current patch set that I plan to send to Linus. And
    I consider it a waste of time to sort through and figure out what if
    any of this 1200 line patch is really worthwhile. (A quick scan
    didn't find anything, although if there are some places where I'm
    missing a pr_cont / KERN_CONT in a commonly used --- non debug ---
    codepath I'd be willing to fix it.)

    - Ted

     \ /
      Last update: 2012-03-19 05:13    [W:0.020 / U:1.012 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site