Messages in this thread | | | Date | Fri, 16 Mar 2012 09:03:57 -0700 | From | David Daney <> | Subject | Re: [PATCH 1/9] ext4: Add -DDEBUG to Makefile |
| |
On 03/15/2012 05:07 PM, Joe Perches wrote: > Add -DDEBUG to enable future use of pr_debug. > No changes to objects as no DEBUG uses currently exist. > > Signed-off-by: Joe Perches<joe@perches.com> > --- > fs/ext4/Makefile | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/fs/ext4/Makefile b/fs/ext4/Makefile > index 56fd8f86..617a5d8 100644 > --- a/fs/ext4/Makefile > +++ b/fs/ext4/Makefile > @@ -2,6 +2,8 @@ > # Makefile for the linux ext4-filesystem routines. > # > > +ccflags-$(CONFIG_EXT4_FS) := -DDEBUG
In many other susbsystems/drivers, the definition of DEBUG is gated by a separate Kconfig symbol used to select debugging just for that susbsystem/driver (see CONFIG_MMC_DEBUG for example).
Why aren't you doing the same here?
David Daney
| |