Messages in this thread | | | From | Paul Turner <> | Date | Fri, 17 Feb 2012 02:54:55 -0800 | Subject | Re: [RFC PATCH 14/14] sched: implement usage tracking |
| |
On Thu, Feb 16, 2012 at 5:37 AM, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote: > On Wed, 2012-02-01 at 17:38 -0800, Paul Turner wrote: >> static inline void update_rq_runnable_avg(struct rq *rq, int runnable) >> { >> - __update_entity_runnable_avg(rq->clock_task, &rq->avg, runnable); >> + __update_entity_runnable_avg(rq->clock_task, &rq->avg, runnable, >> + runnable); > > Its not immediately obvious why we use @runnable for @running,
Isn't it? An rq is the root of all scheduling -- if there are any runnable tasks than one of them better be running when this is called.
I can add a comment to this effect. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |