Messages in this thread | | | Date | Mon, 24 Dec 2012 10:25:49 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH 17/25] wm97xx: don't use [delayed_]work_pending() |
| |
Hello, Dmitry.
On Sun, Dec 23, 2012 at 01:54:50AM -0800, Dmitry Torokhov wrote: > This is not 100% equivalent transformation as now we schedule first and > disable IRQ later... Anyway, I think the driver shoudl be converted to > threaded IRQ instead. Mark, does the patch below make any sense to you?
Yeah, I think the conversion is actually broken. There isn't anything which prevents work item execution racing against irq disabling. I agree the right thing to do is using threaded irq handler.
Thanks!
-- tejun
| |