lkml.org 
[lkml]   [2012]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 17/25] wm97xx: don't use [delayed_]work_pending()
    Date
    There's no need to test whether a (delayed) work item in pending
    before queueing, flushing or cancelling it. Most uses are unnecessary
    and quite a few of them are buggy.

    Remove unnecessary pending tests from wm97xx. Instead of testing
    work_pending(), use the return value of queue_work() to decide whether
    to disable IRQ or not.

    Only compile tested.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
    Cc: Liam Girdwood <lrg@slimlogic.co.uk>
    Cc: linux-input@vger.kernel.org
    Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    ---
    Please let me know how this patch should be routed. I can take it
    through the workqueue tree if necessary.

    Thanks.

    drivers/input/touchscreen/wm97xx-core.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c
    index 5dbe73a..fd16c63 100644
    --- a/drivers/input/touchscreen/wm97xx-core.c
    +++ b/drivers/input/touchscreen/wm97xx-core.c
    @@ -363,10 +363,8 @@ static irqreturn_t wm97xx_pen_interrupt(int irq, void *dev_id)
    {
    struct wm97xx *wm = dev_id;

    - if (!work_pending(&wm->pen_event_work)) {
    + if (queue_work(wm->ts_workq, &wm->pen_event_work))
    wm->mach_ops->irq_enable(wm, 0);
    - queue_work(wm->ts_workq, &wm->pen_event_work);
    - }

    return IRQ_HANDLED;
    }
    --
    1.8.0.2


    \
     
     \ /
      Last update: 2012-12-22 04:21    [W:4.159 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site