lkml.org 
[lkml]   [2012]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: + fork-unshare-remove-dead-code.patch added to -mm tree
> --- a/kernel/fork.c~fork-unshare-remove-dead-code
> +++ a/kernel/fork.c
> @@ -1792,10 +1792,8 @@ SYSCALL_DEFINE1(unshare, unsigned long,
> exit_sem(current);
> }
>
> - if (new_nsproxy) {
> + if (new_nsproxy)
> switch_task_namespaces(current, new_nsproxy);
> - new_nsproxy = NULL;
> - }
>
> task_lock(current);
>
> @@ -1819,9 +1817,6 @@ SYSCALL_DEFINE1(unshare, unsigned long,
> task_unlock(current);
> }
>
> - if (new_nsproxy)
> - put_nsproxy(new_nsproxy);
> -

Agreed.

Perhaps it also makes sense to kill
"if (new_fs || new_fd || do_sysvsem || new_nsproxy)" ? This check
buys nothing. And without this check it is obvious why we do not
need put_nsproxy() after this block.

Oleg.



\
 
 \ /
  Last update: 2012-10-31 16:21    [W:0.049 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site