| Date | Fri, 19 Oct 2012 13:34:21 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix |
| |
On Mon, Oct 15, 2012 at 01:09:04PM -0700, Kent Overstreet wrote: > This adds a pointer to the bvec array to struct bio_integrity_payload, > instead of the bvecs always being inline; then the bvecs are allocated > with bvec_alloc_bs(). > > This is needed eventually for immutable bio vecs - immutable bvecs > aren't useful if we still have to copy them, hence the need for the > pointer. Less code is always nice too, though. > > Also fix an amusing bug in bio_integrity_split() - struct bio_pair > doesn't have the integrity bvecs after the bio_integrity_payloads, so > there was a buffer overrun. The code was confusing pointers with arrays.
Ummm... patch description doesn't agree with the patch content?
-- tejun
|