Messages in this thread | | | Subject | Re: [PATCH v4 1/2] block: Fix a buffer overrun in bio_integrity_split() | From | "Martin K. Petersen" <> | Date | Wed, 24 Oct 2012 12:34:14 -0400 |
| |
>>>>> "Vivek" == Vivek Goyal <vgoyal@redhat.com> writes:
Vivek> Initially he had reordered the bio_pair fields but there were Vivek> couple of issues. We could not assume that there is no padding Vivek> between fields and secondly some of the initializtion of looked Vivek> plain ugly.
Vivek> IMHO, introduction of bip_vec to fix this issue is small and Vivek> cleaner then reordering fields.
I agree.
-- Martin K. Petersen Oracle Linux Engineering
| |