Messages in this thread | | | From | "Sam Bradshaw (sbradshaw)" <> | Subject | RE: [PATCH] mtip32xx: rename the confusing argument 'barrier', of mtip_hw_submit_io() | Date | Mon, 23 Jan 2012 20:21:35 +0000 |
| |
> -----Original Message----- > From: Christoph Hellwig [mailto:hch@infradead.org] > Subject: Re: [PATCH] mtip32xx: rename the confusing argument 'barrier', of > mtip_hw_submit_io() > > On Wed, Jan 18, 2012 at 05:29:40PM -0800, Asai Thambi SP wrote: > > This device does not support write cache, hence renamed confusing argument > > 'barrier' to 'fua'. Setting of FUA bit is done in all IOs for compatibility. > > That's not correct, you set it if REQ_FUA is set, which won't ever be > set given how you configure the queue. I.e. it's dead code that can be > removed.
That was done intentionally to minimize the scope of changes for future variants of the P320 that do support write cache. We'll go ahead and remove it, however, since it is presently dead code.
| |