Messages in this thread | | | Date | Mon, 23 Jan 2012 15:09:23 -0500 | From | Christoph Hellwig <> | Subject | Re: [PATCH] mtip32xx: rename the confusing argument 'barrier', of mtip_hw_submit_io() |
| |
On Wed, Jan 18, 2012 at 05:29:40PM -0800, Asai Thambi SP wrote: > This device does not support write cache, hence renamed confusing argument > 'barrier' to 'fua'. Setting of FUA bit is done in all IOs for compatibility.
That's not correct, you set it if REQ_FUA is set, which won't ever be set given how you configure the queue. I.e. it's dead code that can be removed.
| |