Messages in this thread | | | Subject | checkpatch regression: error on #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt | From | Joe Perches <> | Date | Wed, 11 Jan 2012 13:12:34 -0800 |
| |
Current checkpatch gives:
ERROR: Macros with complex values should be enclosed in parenthesis #18: FILE: net/ethernet/broadcom/bnx2x/bnx2x_cmn.c:18: +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
due to:
commit b3dfb9bc52e9a751e47bbc92d3a3f07e9a0029c5 Author: Andy Whitcroft <apw@canonical.com> Date: Thu Dec 22 16:04:25 2011 +1100
checkpatch: correctly track the end of preprocessor commands in context
When looking for a statement we currently run on through preprocessor commands. This means that a header file with just definitions is parsed over and over again combining all of the lines from the current line to the end of file leading to severe performance issues.
Fix up context accumulation to track preprocessor commands and stop when reaching the end of them. At the same time vastly simplify the #define handling.
| |