lkml.org 
[lkml]   [2012]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86,sched: Fix sched_smt_power_savings totally broken

* Suresh Siddha <suresh.b.siddha@intel.com> wrote:

> On Tue, 2012-01-10 at 00:58 -0500, Youquan Song wrote:
> > Thanks Peter! Here is the patch.
>
> Youquan, As far as I know both the
> sched_smt_power_savings/sched_mc_power_savings are broken for atleast an
> year.

We want a single knob, sched_power_savings - with the mc_ and
smt_ ones still kept and aliased to sched_power_savings, for
compatibility reasons.

As Peter said, the other reasonable option is to have no knob at
all and restart this code from scratch.

The other thing we should do is to add sane defaults: to turn on
sched_power_savings *AUTOMATICALLY* when a system is obviously
battery driven and turn it off when the system is obviously AC
driven. User-space can still implement policy and override the
kernel's default, but there's absolutely no excuse to not offer
this default ourselves.

The kernel default should probably change automatically on
powerloss and battery events as well. (again, if user-space
wants to do it itself, it can do it and we won't interfere.)

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-01-10 10:21    [W:0.101 / U:1.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site