Messages in this thread Patch in this message | | | Date | Mon, 05 Sep 2011 06:22:57 +0000 | From | Shen Canquan <> | Subject | Re : [PATCH] acpi: Fix hot cpu remove problem on acpi subsystem |
| |
Hi Len, I have tested more than 10000 times of cpu remove and add function in the latest kernel. The result of test is ok. The flow of my test program is bellow: (1) get random number of cpu . (2) call xm vcpu-set <n> . depend on current cpu number. it simulate the function of add or remove cpu at random. (3) get the random number between 1 and 10. (4) sleep random seconds which get from step 3. (5) repeat from step 1 to step 4.
what's your opinion of this patch?
-- shencanquan ________________________________________ 发件人: linux-kernel-owner@vger.kernel.org [linux-kernel-owner@vger.kernel.org] 代表 Shen Canquan [shencanquan@huawei.com] 发送时间: 2011年8月30日 14:35 到: lenb@kernel.org; rui.zhao@intel.com; shemminger@vyatta.com; yakui.zhao@intel.com Cc: xiaowei.yang@huawei.com; hanweidong; linux-kernel@vger.kernel.org; i@vger.kernel.org 主题: [PATCH] acpi: Fix hot cpu remove problem on acpi subsystem
In Xen virtualization environment, When I used xen tools (xm vcpu-set vcpu_number ) to test the vcpu add and remove, I found it is failure on vcpu remove, I found the reason is that nothing to do when cpu remove in acpi_processor_hotplug_notify function, so I add the code of send the OFFLINE message to udev and add the rule of udev. it is ok on vcpu remove. Signed-off-by: Shen canquan <shencanquan@huawei.com> --- drivers/acpi/processor_driver.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c index a4e0f1b..a1c564f 100644 --- a/drivers/acpi/processor_driver.c +++ b/drivers/acpi/processor_driver.c @@ -677,6 +677,8 @@ static void acpi_processor_hotplug_notify(acpi_handle handle, "Driver data is NULL, dropping EJECT\n"); return; } + + kobject_uevent(&device->dev.kobj, KOBJ_OFFLINE); break; default: ACPI_DEBUG_PRINT((ACPI_DB_INFO, -- 1.7.6.msysgit.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | |