| Date | Mon, 5 Sep 2011 05:42:52 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 11/13] dcache: use a dispose list in select_parent |
| |
> -/** > * shrink_dcache_sb - shrink dcache for a superblock > * @sb: superblock > * > @@ -1073,7 +1054,7 @@ EXPORT_SYMBOL(have_submounts); > * drop the lock and return early due to latency > * constraints. > */ > -static long select_parent(struct dentry * parent) > +static long select_parent(struct dentry *parent, struct list_head *dispose)
Btw, the function header comment above select_parent is entirely incorrect after your changes.
Also I'd suggest folding select_parent into shrink_dcache_parent as the split doesn't make a whole lot of sense any more. Maybe factoring it at a different level would make sense, though.
|