Messages in this thread | | | Subject | Re: [PATCH v1 4/4] target: check hex2bin result | From | Mimi Zohar <> | Date | Tue, 20 Sep 2011 23:41:32 -0400 |
| |
On Wed, 2011-09-21 at 02:55 +0300, Andy Shevchenko wrote: > On Tue, Sep 20, 2011 at 10:52 PM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote: > > Now that hex2bin does error checking, on error add debugging error msg. > > > > Changelog v1: > > - hex2bin now returns an int > > > > Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com> > > --- > > drivers/target/target_core_fabric_lib.c | 11 +++++++++-- > > 1 files changed, 9 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/target/target_core_fabric_lib.c b/drivers/target/target_core_fabric_lib.c > > index c4ea3a9..17658ca 100644 > > --- a/drivers/target/target_core_fabric_lib.c > > +++ b/drivers/target/target_core_fabric_lib.c > > @@ -63,6 +63,7 @@ u32 sas_get_pr_transport_id( > > unsigned char *buf) > > { > > unsigned char *ptr; > > + bool ret; > I'm sorry for this, but I guess you meant int?
Sigh, yes of course. As an after thought, I decided to include the 'target' patch. :( > > > > /* > > * Set PROTOCOL IDENTIFIER to 6h for SAS > > > @@ -158,6 +161,8 @@ u32 fc_get_pr_transport_id( > > unsigned char *ptr; > > int i; > > u32 off = 8; > > + bool ret; > Ditto. > > + > > /* > > * PROTOCOL IDENTIFIER is 0h for FCP-2 > > * > Otherwise have my Acked-by. I think Andrew also will be happy.
Thanks for all the reviews/Acks!
Mimi
| |