lkml.org 
[lkml]   [2011]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 4/4] target: check hex2bin result
    Date
    Now that hex2bin does error checking, on error add debugging error msg.

    Changelog v1:
    - hex2bin now returns an int

    Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
    ---
    drivers/target/target_core_fabric_lib.c | 11 +++++++++--
    1 files changed, 9 insertions(+), 2 deletions(-)

    diff --git a/drivers/target/target_core_fabric_lib.c b/drivers/target/target_core_fabric_lib.c
    index c4ea3a9..17658ca 100644
    --- a/drivers/target/target_core_fabric_lib.c
    +++ b/drivers/target/target_core_fabric_lib.c
    @@ -63,6 +63,7 @@ u32 sas_get_pr_transport_id(
    unsigned char *buf)
    {
    unsigned char *ptr;
    + bool ret;

    /*
    * Set PROTOCOL IDENTIFIER to 6h for SAS
    @@ -74,7 +75,9 @@ u32 sas_get_pr_transport_id(
    */
    ptr = &se_nacl->initiatorname[4]; /* Skip over 'naa. prefix */

    - hex2bin(&buf[4], ptr, 8);
    + ret = hex2bin(&buf[4], ptr, 8);
    + if (ret < 0)
    + pr_debug("sas transport_id: invalid hex string\n");

    /*
    * The SAS Transport ID is a hardcoded 24-byte length
    @@ -158,6 +161,8 @@ u32 fc_get_pr_transport_id(
    unsigned char *ptr;
    int i;
    u32 off = 8;
    + bool ret;
    +
    /*
    * PROTOCOL IDENTIFIER is 0h for FCP-2
    *
    @@ -174,7 +179,9 @@ u32 fc_get_pr_transport_id(
    i++;
    continue;
    }
    - hex2bin(&buf[off++], &ptr[i], 1);
    + ret = hex2bin(&buf[off++], &ptr[i], 1);
    + if (ret < 0)
    + pr_debug("fc transport_id: invalid hex string\n");
    i += 2;
    }
    /*
    --
    1.7.3.4


    \
     
     \ /
      Last update: 2011-09-20 21:57    [W:0.022 / U:1.492 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site