Messages in this thread Patch in this message | | | Date | Wed, 3 Aug 2011 14:10:13 +1000 | From | Stephen Rothwell <> | Subject | linux-next: build failure after merge of the moduleh tree |
| |
Hi Paul,
After merging the moduleh tree, today's linux-next build (x86_64 allmodconfig) failed like this:
drivers/md/persistent-data/dm-transaction-manager.c:137:1: warning: data definition has no type or storage class drivers/md/persistent-data/dm-transaction-manager.c:137:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' drivers/md/persistent-data/dm-transaction-manager.c:137:1: warning: parameter names (without types) in function declaration drivers/md/persistent-data/dm-transaction-manager.c:143:1: warning: data definition has no type or storage class drivers/md/persistent-data/dm-transaction-manager.c:143:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' drivers/md/persistent-data/dm-transaction-manager.c:143:1: warning: parameter names (without types) in function declaration drivers/md/persistent-data/dm-transaction-manager.c:158:1: warning: data definition has no type or storage class drivers/md/persistent-data/dm-transaction-manager.c:158:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' drivers/md/persistent-data/dm-transaction-manager.c:158:1: warning: parameter names (without types) in function declaration drivers/md/persistent-data/dm-transaction-manager.c:169:1: warning: data definition has no type or storage class drivers/md/persistent-data/dm-transaction-manager.c:169:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' drivers/md/persistent-data/dm-transaction-manager.c:169:1: warning: parameter names (without types) in function declaration drivers/md/persistent-data/dm-transaction-manager.c:292:1: warning: data definition has no type or storage class drivers/md/persistent-data/dm-transaction-manager.c:292:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' drivers/md/persistent-data/dm-transaction-manager.c:292:1: warning: parameter names (without types) in function declaration drivers/md/persistent-data/dm-transaction-manager.c:303:1: warning: data definition has no type or storage class drivers/md/persistent-data/dm-transaction-manager.c:303:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' drivers/md/persistent-data/dm-transaction-manager.c:303:1: warning: parameter names (without types) in function declaration drivers/md/persistent-data/dm-transaction-manager.c:402:1: warning: data definition has no type or storage class drivers/md/persistent-data/dm-transaction-manager.c:402:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' drivers/md/persistent-data/dm-transaction-manager.c:402:1: warning: parameter names (without types) in function declaration drivers/md/persistent-data/dm-transaction-manager.c:413:1: warning: data definition has no type or storage class drivers/md/persistent-data/dm-transaction-manager.c:413:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' drivers/md/persistent-data/dm-transaction-manager.c:413:1: warning: parameter names (without types) in function declaration
Caused by an interaction between the module.h split and commit 90616764c64f ("The persistent-data library offers a re-usable framework for the storage").
I have applied the below patch for today. This file should really have included module.h anyway ...
From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Wed, 3 Aug 2011 14:06:38 +1000 Subject: [PATCH] dm: dm-transaction-manager.c needs export.h
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- .../md/persistent-data/dm-transaction-manager.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/md/persistent-data/dm-transaction-manager.c b/drivers/md/persistent-data/dm-transaction-manager.c index 4284921..bf9b61b 100644 --- a/drivers/md/persistent-data/dm-transaction-manager.c +++ b/drivers/md/persistent-data/dm-transaction-manager.c @@ -10,6 +10,7 @@ #include "dm-persistent-data-internal.h" #include <linux/slab.h> +#include <linux/export.h> #include <linux/device-mapper.h> #define DM_MSG_PREFIX "transaction manager" -- 1.7.5.4 -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
| |