Messages in this thread | | | Date | Tue, 16 Aug 2011 01:11:22 -0400 | From | Konrad Rzeszutek Wilk <> | Subject | Re: [PATCH 3.1-rc2] xen: self-balloon needs module.h |
| |
On Mon, Aug 15, 2011 at 09:41:43PM -0700, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@xenotime.net> > > Fix build errors (found when CONFIG_SYSFS is not enabled): > > drivers/xen/xen-selfballoon.c:446: warning: data definition has no type or storage class > drivers/xen/xen-selfballoon.c:446: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' > drivers/xen/xen-selfballoon.c:446: warning: parameter names (without types) in function declaration > drivers/xen/xen-selfballoon.c:485: error: expected declaration specifiers or '...' before string constant > drivers/xen/xen-selfballoon.c:485: warning: data definition has no type or storage class > drivers/xen/xen-selfballoon.c:485: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' > drivers/xen/xen-selfballoon.c:485: warning: function declaration isn't a prototype > > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
I think .. yeah I do have it queued it up in my stable/bug.fixes tree, .. ah but did not push it (albeit it was in #linux-next which was pushed).
Linus, if you want to take it, it has my Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
or if you just want to do a git pull, I will shortly send an email asking to pull the above mentioned tree.
> --- > drivers/xen/xen-selfballoon.c | 1 + > 1 file changed, 1 insertion(+) > > and will need <linux/export.h> when module.h is split up. > > --- lnx-31-rc2.orig/drivers/xen/xen-selfballoon.c > +++ lnx-31-rc2/drivers/xen/xen-selfballoon.c > @@ -70,6 +70,7 @@ > #include <linux/kernel.h> > #include <linux/mm.h> > #include <linux/mman.h> > +#include <linux/module.h> > #include <linux/workqueue.h> > #include <xen/balloon.h> > #include <xen/tmem.h>
| |