lkml.org 
[lkml]   [2011]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [tip:x86/vdso] x86, vsyscall: Add missing <asm/fixmap.h> to arch/x86/mm/fault.c
    On Tue, 16 Aug 2011 15:27:18 GMT tip-bot for H. Peter Anvin wrote:

    > Commit-ID: fab1167c4698e3ff11ebb06281d78def6c53728b
    > Gitweb: http://git.kernel.org/tip/fab1167c4698e3ff11ebb06281d78def6c53728b
    > Author: H. Peter Anvin <hpa@linux.intel.com>
    > AuthorDate: Mon, 15 Aug 2011 22:28:56 -0700
    > Committer: H. Peter Anvin <hpa@linux.intel.com>
    > CommitDate: Tue, 16 Aug 2011 08:04:02 -0700
    >
    > x86, vsyscall: Add missing <asm/fixmap.h> to arch/x86/mm/fault.c
    >
    > arch/x86/mm/fault.c now depend on having the symbol VSYSCALL_START
    > defined, which is best handled by including <asm/fixmap.h> (it isn't
    > unreasonable we may want other fixed addresses in this file in the
    > future, and so it is cleaner than including <asm/vsyscall.h>
    > directly.)
    >
    > This addresses an x86-64 allnoconfig build failure. On other
    > configurations it was masked by an indirect path:
    >
    > <asm/smp.h> -> <asm/apic.h> -> <asm/fixmap.h> -> <asm/vsyscall.h>
    >
    > ... however, the first such include is conditional on CONFIG_X86_LOCAL_APIC.
    >
    > Originally-by: Randy Dunlap <rdunlap@xenotime.net>
    > Cc: Linus Torvalds <torvalds@linux-foundation.org>
    > Link: http://lkml.kernel.org/r/CA%2B55aFxsOMc9=p02r8-QhJ=h=Mqwckk4_Pnx9LQt5%2BfqMp_exQ@mail.gmail.com

    That link gives me:
    "No such Message-ID known"

    > Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
    > ---
    > arch/x86/mm/fault.c | 1 +
    > 1 files changed, 1 insertions(+), 0 deletions(-)
    >
    > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
    > index 247aae3..f2d4c9d 100644
    > --- a/arch/x86/mm/fault.c
    > +++ b/arch/x86/mm/fault.c
    > @@ -17,6 +17,7 @@
    > #include <asm/traps.h> /* dotraplinkage, ... */
    > #include <asm/pgalloc.h> /* pgd_*(), ... */
    > #include <asm/kmemcheck.h> /* kmemcheck_*(), ... */
    > +#include <asm/fixmap.h> /* VSYSCALL_START */

    Nit: asm/fixmap.h does not provide VSYSCALL_START. whatever.
    >
    > /*
    > * Page fault error code bits:
    > --


    ---
    ~Randy
    *** Remember to use Documentation/SubmitChecklist when testing your code ***


    \
     
     \ /
      Last update: 2011-08-16 19:25    [W:0.027 / U:1.256 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site