lkml.org 
[lkml]   [2011]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
SubjectRE: [PATCH RESEND] Input: tegra-kbc - correct call to input_free_device
Axel Lin wrote at Thursday, August 11, 2011 2:49 AM:
> If kzalloc for kbc fails, then we have NULL pointer dereference while
> calling input_free_device(kbc->idev) in the error handling.
> So it is safer to always use the original name, input_dev.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Reviewed-by: Stephen Warren <swarren@nvidia.com>

> ---
> drivers/input/keyboard/tegra-kbc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
> index 2b3b73e..8e40f2b 100644
> --- a/drivers/input/keyboard/tegra-kbc.c
> +++ b/drivers/input/keyboard/tegra-kbc.c
> @@ -701,7 +701,7 @@ err_iounmap:
> err_free_mem_region:
> release_mem_region(res->start, resource_size(res));
> err_free_mem:
> - input_free_device(kbc->idev);
> + input_free_device(input_dev);
> kfree(kbc);
>
> return err;
> --
> 1.7.4.1

--
nvpublic

\
 
 \ /
  Last update: 2011-08-11 18:45    [W:0.057 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site